Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Decouple constellations #118

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

tinypell3ts
Copy link
Contributor

Summary

This pull request removes the concepts of constellations and changing the naming convention of Star to App.

Description

To simplify the app creation process through composability and modularisation, we plan to decouple the Constellation and Reward token into a separate entity that can be created at a later date. Instead of developers having to create a constellation before an application, they can now create their OPENFORMAT App and, when or if ready, associate a reward token (ERC20) with their app or multiple apps.

Type of Change

Please check the boxes that apply to your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (changes to documentation only)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Testing

I've updated the existing tests and remove any Constellation tests.

Checklist

  • I have read the CONTRIBUTING.md document
  • I have followed the project's style guide
  • I have added or updated tests to cover my changes
  • All new and existing tests passed
  • My changes generate no new warnings or errors
  • I have made corresponding changes to the documentation
  • I have checked that my changes do not introduce any new security vulnerabilities
  • I have provided a clear and concise description of my changes
  • I have linked to the related issue or bounty, if applicable

@tinypell3ts tinypell3ts added the enhancement New feature or request label Apr 10, 2024
@tinypell3ts tinypell3ts self-assigned this Apr 10, 2024
Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: abbfc89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openformat/contracts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tinypell3ts tinypell3ts merged commit 9c08e89 into main Apr 11, 2024
2 checks passed
@tinypell3ts tinypell3ts deleted the feature/remove-constellations branch April 11, 2024 09:08
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants