feature: Update reward facet to mint badges #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summery
adds
mintBadge
andbatchMintBadge
function toRewardsFacet
contractadds
ERC721Minted
event property for non badge implementations of ERC721 contracts moving forwardsupdates
badgeMinted
event property names and data typesupdates scripts for deploying
RewardsFacet
adds update script for this PR
make update-RewardsFacet
adds tests for
RewardsFacet
functionsmintTo
,batchMintTo
and multicallDescription
In the end chose to add functionality and tweak events slightly to better represent what is happening.
My main concern is having large ripple effects to the api, when this is deployed.
Hopefully mostly mitigated as previous functionality should work but will have to be careful when updating the subgraph to index all events with the signature
event BadgeMinted(address token, uint256 quantity, address to, bytes32 id, bytes32 activityType, string uri)
before this update.Issues
resolves issue OF-124