Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Update reward facet to mint badges #126

Merged
merged 7 commits into from
May 30, 2024

Conversation

george-openformat
Copy link
Contributor

@george-openformat george-openformat commented May 16, 2024

Summery

adds mintBadge and batchMintBadge function to RewardsFacet contract
adds ERC721Minted event property for non badge implementations of ERC721 contracts moving forwards
updates badgeMinted event property names and data types

updates scripts for deploying RewardsFacet
adds update script for this PR make update-RewardsFacet
adds tests for RewardsFacet functions mintTo, batchMintTo and multicall

Description

In the end chose to add functionality and tweak events slightly to better represent what is happening.
My main concern is having large ripple effects to the api, when this is deployed.

Hopefully mostly mitigated as previous functionality should work but will have to be careful when updating the subgraph to index all events with the signature event BadgeMinted(address token, uint256 quantity, address to, bytes32 id, bytes32 activityType, string uri) before this update.

Issues

resolves issue OF-124

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 6aaa086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openformat/contracts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@george-openformat george-openformat marked this pull request as ready for review May 20, 2024 11:26
@george-openformat george-openformat changed the title Sketch: Update reward facet to mint badges feature: Update reward facet to mint badges May 20, 2024
@george-openformat george-openformat merged commit a74d991 into main May 30, 2024
2 checks passed
@george-openformat george-openformat deleted the feature--update-rewards-facet branch May 30, 2024 16:03
@github-actions github-actions bot mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants