Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/of 236 remove operator filter from all erc721 implementations #129

Conversation

george-openformat
Copy link
Contributor

Summary

Removes open sea's operation filter from contracts.
The reason being was that the operation filter wasn't deployed to sepolia so it causes the deployment to revert.

Me and @tinypell3ts did this at some point on arbitrum-sepolia and I believe the ERC721 contracts were deployed the way seen in this PR. This to bring the codebase inline with what is deployed.

I ran into the same issue when deploying the staging contracts see PR #128 , and so the Base and LazyMint contracts here are what are currently deployed.

Related Issue/Bounty

OF-236

Type of Change

Please check the boxes that apply to your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (changes to documentation only)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Testing

N/A no tests were written for operation filter functionality, all tests pass with forge test

Copy link

changeset-bot bot commented Jun 11, 2024

⚠️ No Changeset found

Latest commit: 741ec0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from feature/of-209-add-contract-staging-deployment to main June 12, 2024 08:05
@george-openformat george-openformat merged commit 0b2ca55 into main Jun 12, 2024
2 checks passed
@george-openformat george-openformat deleted the feature/of-236-remove-operator-filter-from-all-erc721-implementations branch June 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants