Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/of 327 remove platform and application fees from contracts #139

Open
wants to merge 11 commits into
base: staging
Choose a base branch
from

Conversation

george-openformat
Copy link
Contributor

@george-openformat george-openformat commented Aug 7, 2024

Summary

Removes all platform and application fee logic from contracts.
No deployments/updates have happened yet.

Description

The reason for this is to account for the infeasibility of currently charging per transaction when the the business goals are focused on delivering micro payments. In order to save gas fees and make it viable we have implemented charging functionality (PR #134 ) that presums the fee is calculated off-chain for batching together multiple transactions and submitted as a single transaction.

Removing the application and platform fees is a commitment to this approach, and removes unused functionality. It also makes things clearer for an audit in the future.

  • remove application fee and platform fee logic
  • remove related tests
  • update related scripts

Related Issue/Bounty

OF-327

Type of Change

Please check the boxes that apply to your pull request:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (no functional changes)

Testing

  • Tests have been updated and all pass.

I have also successfully run the update script make update-removeApplicationAndPlatformFees locally against a deployment from staging branch.

git checkout staging
make deploy
git checkout feature/of-327-remove-platform-and-application-fees-from-contracts
make clean
make update-removeApplicationAndPlatformFees

Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 2819e11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@george-openformat george-openformat marked this pull request as ready for review August 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants