-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/of 327 remove platform and application fees from contracts #139
base: staging
Are you sure you want to change the base?
Feature/of 327 remove platform and application fees from contracts #139
Conversation
|
Summary
Removes all platform and application fee logic from contracts.
No deployments/updates have happened yet.
Description
The reason for this is to account for the infeasibility of currently charging per transaction when the the business goals are focused on delivering micro payments. In order to save gas fees and make it viable we have implemented charging functionality (PR #134 ) that presums the fee is calculated off-chain for batching together multiple transactions and submitted as a single transaction.
Removing the application and platform fees is a commitment to this approach, and removes unused functionality. It also makes things clearer for an audit in the future.
Related Issue/Bounty
OF-327
Type of Change
Please check the boxes that apply to your pull request:
Testing
I have also successfully run the update script
make update-removeApplicationAndPlatformFees
locally against a deployment from staging branch.