Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added prefill tab to number component edit #193

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Added prefill tab to number component edit #193

merged 2 commits into from
Nov 12, 2024

Conversation

robinmolen
Copy link
Contributor

Partly solves open-formulieren/open-forms#4813

Allow prefill configuration on number fields

@robinmolen robinmolen requested a review from vaszig November 8, 2024 14:45
@robinmolen robinmolen linked an issue Nov 8, 2024 that may be closed by this pull request
Add prefill to number field open-formulieren/open-forms#4813
Closed
@robinmolen robinmolen marked this pull request as draft November 8, 2024 14:48
vaszig
vaszig approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@vaszig vaszig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me!I guess we do not need any stories for this so I believe it's ready to go when we update the PR with the new version of the types repository. Let's check one more time the CI just to be sure.

  • It's a draft due to the types repository right?

@robinmolen
Copy link
Contributor Author

Yeah this is set to draft due to the types repository.

@robinmolen robinmolen force-pushed the feature/4813-number-component-prefill branch from 204d7e5 to 511f547 Compare November 11, 2024 11:13
@robinmolen robinmolen marked this pull request as ready for review November 11, 2024 11:46
@robinmolen
Copy link
Contributor Author

I've updated the types dependency and added prefill config to the number type storybook test.

If you are still ok with this, then we can merge it :)

@sergei-maertens sergei-maertens merged commit 2b5adeb into main Nov 12, 2024
23 checks passed
@sergei-maertens sergei-maertens deleted the feature/4813-number-component-prefill branch November 12, 2024 08:49
@sergei-maertens
Copy link
Member

Merged, but we will do a release later this week since I'd like to have #194 and #195 in the release too, and some pending cosign improvements work (#192)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaszig vaszig vaszig approved these changes

@sergei-maertens sergei-maertens sergei-maertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prefill to number field
3 participants
@robinmolen @sergei-maertens @vaszig