-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#9] Make retrieval of Open Forms choices lazy #11
Conversation
856a8d0
to
3abb489
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=======================================
Coverage 95.03% 95.04%
=======================================
Files 20 20
Lines 504 505 +1
=======================================
+ Hits 479 480 +1
Misses 25 25 ☔ View full report in Codecov by Sentry. |
3abb489
to
a9351a6
Compare
fe98b55
to
79493d2
Compare
79493d2
to
d4aec32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected, could you also add a test that initializes the field twice and checks that the network call is only done once (and done again once the cache key is invalidated)? :)
Issue (Open Inwoner): https://taiga.maykinmedia.nl/project/open-inwoner/issue/2236