Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9] Make retrieval of Open Forms choices lazy #11

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

pi-sigma
Copy link
Collaborator

@pi-sigma pi-sigma force-pushed the issue/9-default-choices branch from 856a8d0 to 3abb489 Compare April 29, 2024 10:43
@pi-sigma pi-sigma changed the title [#9] Replace model form fields with regular form fields [#9] Provide Mixin to retrieve field choices dynamically Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (1c90c11) to head (a9351a6).
Report is 3 commits behind head on main.

Current head a9351a6 differs from pull request most recent head 105d753

Please upload reports for the commit 105d753 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   95.03%   95.04%           
=======================================
  Files          20       20           
  Lines         504      505    +1     
=======================================
+ Hits          479      480    +1     
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the issue/9-default-choices branch 2 times, most recently from fe98b55 to 79493d2 Compare May 28, 2024 10:37
@pi-sigma pi-sigma force-pushed the issue/9-default-choices branch from 79493d2 to d4aec32 Compare May 28, 2024 10:45
@pi-sigma pi-sigma changed the title [#9] Provide Mixin to retrieve field choices dynamically [#9] Make retrieval of Open Forms choices lazy May 28, 2024
@pi-sigma pi-sigma requested a review from stevenbal May 28, 2024 10:54
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected, could you also add a test that initializes the field twice and checks that the network call is only done once (and done again once the cache key is invalidated)? :)

@pi-sigma pi-sigma requested a review from stevenbal June 18, 2024 08:53
@stevenbal stevenbal merged commit c2c9db7 into main Jun 21, 2024
11 checks passed
@stevenbal stevenbal deleted the issue/9-default-choices branch June 21, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants