Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mocks with VCR casettes for client testing #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace mocks with VCR casettes for client testing #14

wants to merge 2 commits into from

Conversation

pi-sigma
Copy link
Collaborator

@pi-sigma pi-sigma commented Jul 25, 2024 •
edited
Loading

  • The PR eplaces mocks with VCR casettes and class-based tests with function-based tests for the test_client module.
  • Support for Python 3.9/3.10 and Django 3.2/4.0 has been removed, support for Python 3.12 and Django 4.2 added (we only need to support Django LTS versions going forward).

@pi-sigma pi-sigma marked this pull request as draft July 25, 2024 15:22
@pi-sigma pi-sigma force-pushed the refactor/vcr-tests branch 14 times, most recently from e22d57a to f319ec8 Compare July 31, 2024 08:33
@pi-sigma pi-sigma changed the title Replace mocks with vcr casettes for testing Replace mocks with VCR casettes for client testing Jul 31, 2024
@pi-sigma pi-sigma force-pushed the refactor/vcr-tests branch from f319ec8 to c847888 Compare July 31, 2024 08:42
@pi-sigma pi-sigma force-pushed the refactor/vcr-tests branch from c847888 to bc49d94 Compare July 31, 2024 09:36
@pi-sigma pi-sigma marked this pull request as ready for review July 31, 2024 10:24
@pi-sigma pi-sigma requested a review from sergei-maertens July 31, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens Awaiting requested review from sergei-maertens

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pi-sigma