Skip to content

Commit

Permalink
🐛 Fix transparent borders for buttons on visible focus
Browse files Browse the repository at this point in the history
  • Loading branch information
sergei-maertens committed Oct 31, 2023
1 parent 9feb83b commit dc10caa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,15 @@ should be set:
* ``--utrecht-button-secondary-action-danger-background-color`` takes the value of the old ``--of-button-danger-bg``
* ``--utrecht-button-secondary-action-danger-color`` takes the value of the old ``--of-button-danger-fg``
* ``--utrecht-button-secondary-action-focus-border-color`` takes the value of the old ``--of-color-focus-border``
* ``--utrecht-button-subtle-danger-background-color`` takes the value of ``--of-color-danger``
* ``--utrecht-button-subtle-danger-color`` takes the value of ``--of-color-danger``
* ``--utrecht-button-subtle-danger-background-color`` takes the value of ``--of-color-bg``
* ``--utrecht-button-subtle-danger-hover-background-color`` takes the value ``--of-color-bg``
* ``--utrecht-button-subtle-danger-active-background-color`` takes the value of the old ``--of-button-danger-active-bg``
* ``--utrecht-button-disabled-color``. This does not take the value of an old token. For the
Open Forms theme this is now ``#ffffff``.
* ``--utrecht-button-disabled-background-color``. This does not take the value of an old token,
the colour was previously obtained by graying out the primary button. For the Open Forms theme,
this is now ``#a02017``.
this is now ``#b0b0b0``.
* ``--utrecht-action-disabled-cursor``. This does not take the value of an old token. It controls
the looks of the cursor when hovering a disabled button. For the Open Forms theme, this is now
``not-allowed``.
Expand Down
2 changes: 1 addition & 1 deletion src/scss/components/_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
&:hover {
// However, if the button has visible focus, apply the border color to all borders
// otherwise it looks a bit broken.
&:not(:focus-visible) {
&:not(:focus, :focus-visible) {
border-block-start-color: transparent;
border-inline-start-color: transparent;
}
Expand Down

0 comments on commit dc10caa

Please sign in to comment.