-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
👽 [#724] Fix token imports (CJS -> ESM)
Having looked into various configurations and plugins to automatically get the CommonJS transformed into ESM breaks either dev mode or production builds of Storybook. There are some external plugins for CommonJS transformations, but they either looks sketchy or don't seem to work in obvious ways (in particular @rollup/plugin-commonjs wasn't a success). So I've opted for the simple solution - write a custom plugin that just replaces the CJS export with an ESM export and it works in both dev and prod modes without any additional fuss. In the future, we will process other formats of these token exports, for which the design-token-editor package needs to be upgraded.
- Loading branch information
1 parent
6a1c50d
commit ebac7d5
Showing
4 changed files
with
21 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters