Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#3414] Change co-sign section concerning styling #549

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Sep 15, 2023

Fixes open-formulieren/open-forms#3414

I have chosen to add a padding to the whole div and align it with the buttons above. If you think it would be better to align all the buttons and not the div please let me know.

image

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.60% 🎉

Comparison is base (8e268a1) 70.30% compared to head (efb2994) 70.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   70.30%   70.90%   +0.60%     
==========================================
  Files         207      207              
  Lines        4290     4290              
  Branches     1163     1163              
==========================================
+ Hits         3016     3042      +26     
+ Misses       1239     1216      -23     
+ Partials       35       32       -3     
Files Changed Coverage Δ
src/components/LoginOptions/LoginOptionsDisplay.js 91.66% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig requested a review from SilviaAmAm September 15, 2023 09:06
src/components/LoginOptions/LoginOptionsDisplay.js Outdated Show resolved Hide resolved
src/scss/components/_login-options.scss Outdated Show resolved Hide resolved
src/scss/components/_login-options.scss Outdated Show resolved Hide resolved
src/scss/components/_login-options.scss Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the of-task/3414-change-button-style-for-cosigning branch from 97be094 to efb2994 Compare September 22, 2023 13:31
@sergei-maertens sergei-maertens merged commit ed50f27 into main Sep 25, 2023
12 checks passed
@sergei-maertens sergei-maertens deleted the of-task/3414-change-button-style-for-cosigning branch September 25, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change button for co-signing
2 participants