Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#3385] disabled browser validation on form #554

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

bart-maykin
Copy link
Contributor

fixes open-formulieren/open-forms#3385

disabled browser form validation

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.22% ⚠️

Comparison is base (1f47894) 70.60% compared to head (3802cd3) 70.39%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   70.60%   70.39%   -0.22%     
==========================================
  Files         206      207       +1     
  Lines        4263     4290      +27     
  Branches     1154     1163       +9     
==========================================
+ Hits         3010     3020      +10     
- Misses       1222     1239      +17     
  Partials       31       31              
Files Changed Coverage Δ
src/components/FormStep/index.js 33.47% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Sep 23, 2023
@sergei-maertens sergei-maertens self-assigned this Sep 25, 2023
@sergei-maertens sergei-maertens marked this pull request as ready for review September 25, 2023 07:52
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and does the job

@sergei-maertens sergei-maertens merged commit d31b3b4 into main Sep 25, 2023
15 of 16 checks passed
@sergei-maertens sergei-maertens deleted the feature/3385-email-error branch September 25, 2023 07:58
sergei-maertens pushed a commit that referenced this pull request Sep 25, 2023
sergei-maertens pushed a commit that referenced this pull request Sep 25, 2023
@sergei-maertens
Copy link
Member

sergei-maertens commented Sep 25, 2023

Backports: df5eea5, f62757f, dc11788 and 34ee167

sergei-maertens pushed a commit that referenced this pull request Sep 25, 2023
sergei-maertens pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent errors for email component
2 participants