Implement cursor start/end on Home/End keypress #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution taken from react-select issue/discussion. There is some ambiguity on what the behaviour should be on MacOS, but due to lack of appropriate device we're leaving that as it is, for now.
sergei-maertens
force-pushed
the
issue/437-select-home-end-behaviour
branch
from
44e502f to
5123f46
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
+ Coverage 70.87% 71.15% +0.27%
==========================================
Files 209 209
Lines 4306 4319 +13
Branches 1164 1171 +7
==========================================
+ Hits 3052 3073 +21
+ Misses 1219 1214 -5
+ Partials 35 32 -3
☔ View full report in Codecov by Sentry. |
CharString
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #437
Solution taken from react-select issue/discussion.
There is some ambiguity on what the behaviour should be on MacOS, but due to lack of appropriate device we're leaving that as it is, for now.