Fix cascade of requests firing #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
added
the
needs-backport
Hook dependencies operate on the identity, and the identity of the selectedProducts changes every time on each render, while the contents stay the same. JSON.stringify is the recommended approach to mitigate using non-primivites in hook dependency arrays. Note that the caching masked the issue partially - it caused the request cascade to stop, but the problem still showed with multi- product appointments.
sergei-maertens
force-pushed
the
issue/excessive-appointment-products-requests
branch
from
c10f5c5 to
c8c9684
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 63.64% 70.71% +7.06%
==========================================
Files 191 209 +18
Lines 4162 4319 +157
Branches 1127 1171 +44
==========================================
+ Hits 2649 3054 +405
+ Misses 1513 1230 -283
- Partials 0 35 +35
☔ View full report in Codecov by Sentry. |
SilviaAmAm
approved these changes
Oct 23, 2023
sergei-maertens
deleted the
issue/excessive-appointment-products-requests
branch
sergei-maertens
added a commit
that referenced
this pull request
Oct 23, 2023
Hook dependencies operate on the identity, and the identity of the selectedProducts changes every time on each render, while the contents stay the same. JSON.stringify is the recommended approach to mitigate using non-primivites in hook dependency arrays. Note that the caching masked the issue partially - it caused the request cascade to stop, but the problem still showed with multi- product appointments. Backport-of: #569
|
Backport: 78b1b76 1.4.x and older are not affected, new appointments flow is since 1.5.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #546
Hook dependencies operate on the identity, and the identity of the selectedProducts changes every time on each render, while the contents stay the same.
JSON.stringify is the recommended approach to mitigate using non-primivites in hook dependency arrays.
Note that the caching masked the issue partially - it caused the request cascade to stop, but the problem still showed with multi- product appointments.