Use NL DS components (where possible) for edit grid component #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
===========================================
+ Coverage 55.59% 71.31% +15.72%
===========================================
Files 205 212 +7
Lines 3745 4295 +550
Branches 682 1162 +480
===========================================
+ Hits 2082 3063 +981
+ Misses 1471 1199 -272
+ Partials 192 33 -159
☔ View full report in Codecov by Sentry. |
sergei-maertens
force-pushed
the
refactor/454-nlds-based-editgrid
branch
from
6536008 to
6c35647
Compare
SilviaAmAm
reviewed
Oct 23, 2023
sergei-maertens
force-pushed
the
refactor/454-nlds-based-editgrid
branch
5 times, most recently
from
9c855e7 to
38751c4
Compare
|
Marked as draft again, let's get the button refactor wrapped up first. |
sergei-maertens
force-pushed
the
refactor/454-nlds-based-editgrid
branch
from
38751c4 to
bc9d4bc
Compare
This release contains the (correct) design token values for the edit grid
This sets up the edit grid as a proper themable component using design tokens.
* Replaced the ChooseProductStep React component to use the new EditGrid component * Updated the templates for formio edit grid to emit valid markup and make use of our edit grid component classes
sergei-maertens
force-pushed
the
refactor/454-nlds-based-editgrid
branch
from
ad11a17 to
d59125d
Compare
SilviaAmAm
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #454
Depends on open-formulieren/design-tokens#36
The markup is now more accessible and the theming of the edit grid can be done through design tokens. I tried to go shopping in the utrecht component library but couldn't find any appropriate existing components.
Tasks:
ButtonGroupcomponent for button row