Fix support for address autofill in editgrid #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'row' and 'data' value containers are identical when used outside of a container component, but when inside a container the row provides the local scope. Edit grid is such a container.
sergei-maertens
added
the
needs-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 71.04% 70.69% -0.35%
==========================================
Files 209 210 +1
Lines 4321 4324 +3
Branches 1173 1174 +1
==========================================
- Hits 3070 3057 -13
- Misses 1217 1231 +14
- Partials 34 36 +2
☔ View full report in Codecov by Sentry. |
SilviaAmAm
approved these changes
Oct 23, 2023
sergei-maertens
added a commit
that referenced
this pull request
Oct 23, 2023
The 'row' and 'data' value containers are identical when used outside of a container component, but when inside a container the row provides the local scope. Edit grid is such a container. Backport-of: #574
sergei-maertens
added a commit
that referenced
this pull request
Oct 23, 2023
The 'row' and 'data' value containers are identical when used outside of a container component, but when inside a container the row provides the local scope. Edit grid is such a container. Backport-of: #574
sergei-maertens
added a commit
that referenced
this pull request
Oct 23, 2023
The 'row' and 'data' value containers are identical when used outside of a container component, but when inside a container the row provides the local scope. Edit grid is such a container. Backport-of: #574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/open-forms#2656
Simple fix - now the local scope of data is used instead of the global bucket of data.