[#524] Improve input element accessibility #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaszig
force-pushed
the
of-524/fix-input-accessibility-concerning-suffix
branch
from
2d7a6c2 to
bd1f607
Compare
vaszig
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
===========================================
+ Coverage 55.59% 71.22% +15.63%
===========================================
Files 205 209 +4
Lines 3745 4282 +537
Branches 682 1159 +477
===========================================
+ Hits 2082 3050 +968
+ Misses 1471 1199 -272
+ Partials 192 33 -159 ☔ View full report in Codecov by Sentry. |
vaszig
force-pushed
the
of-524/fix-input-accessibility-concerning-suffix
branch
from
bd1f607 to
416d467
Compare
sergei-maertens
approved these changes
Oct 30, 2023
Attribute aria-labelledby is added in order to reference multiple elements on the page and define the final accessible name for the input element.
vaszig
force-pushed
the
of-524/fix-input-accessibility-concerning-suffix
branch
from
069e484 to
af510ed
Compare
sergei-maertens
deleted the
of-524/fix-input-accessibility-concerning-suffix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #524
A new attribute has been added (
aria-labelledby) in order to combine multiple elements (label,span) and have a proper accessible name. This attribute identifies the element (or elements) that labels the element it is applied to. This was tested with Orca screen reader in Ubuntu (super+alt+sto enable it).References:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-labelledby
https://www.w3.org/WAI/WCAG22/Techniques/aria/ARIA16 (example 3)
https://help.gnome.org/users/orca/stable/index.html.en
Some remarks:
aria-labelledbycan be used to reference another element to define its accessible name, when an element's accessible name needs to use content from elsewhere in the DOMThe
aria-labelledbyproperty value can include content from elements that aren't even visible (CSS display: none, and CSS visibility: hidden)