Refactor container styles to NL DS #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
refactor/3178-page-styles-to-nlds
branch
from
6b38221 to
755aaa1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
- Coverage 71.65% 71.27% -0.38%
==========================================
Files 212 211 -1
Lines 4301 4286 -15
Branches 1164 1161 -3
==========================================
- Hits 3082 3055 -27
- Misses 1184 1196 +12
Partials 35 35
☔ View full report in Codecov by Sentry. |
Merged
1 task
Remove the Layout component usage and instead go for direct styles, making it easier to override the component too as it's more straight forward.
…ss indicator Using CSS grid we can more easily adapt to different viewports to put elements in their right place.
Sayonara and good riddance. This component had become an unmaintainable mess - while the actual layout challenges are easily fixed with some appropriate flexbox/grid layouts in the few places where containers are set up.
sergei-maertens
force-pushed
the
refactor/3178-page-styles-to-nlds
branch
from
755aaa1 to
3446b61
Compare
SilviaAmAm
approved these changes
Nov 10, 2023
The removal of the layout row broke the CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes open-formulieren/open-forms#3178
Requires open-formulieren/design-tokens#42
The
Layout*components are gone and replaced by what is actually required, with nice maintainable CSS 🎉