Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[open-formulieren/open-forms#3611] Make time bounds validation inclusive #596

Merged
merged 4 commits into from
Nov 22, 2023

[open-formulieren/open-forms#3611] Add missing sleep call in test

3598e1a
Select commit
Loading
Failed to load commit list.
Merged

[open-formulieren/open-forms#3611] Make time bounds validation inclusive #596

[open-formulieren/open-forms#3611] Add missing sleep call in test
3598e1a
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Nov 22, 2023 in 0s

72.79% (+0.78%) compared to 7aee061

View this Pull Request on Codecov

72.79% (+0.78%) compared to 7aee061

Details

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7aee061) 72.00% compared to head (3598e1a) 72.79%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/formio/validators/MinMaxTimeValidator.js 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   72.00%   72.79%   +0.78%     
==========================================
  Files         213      213              
  Lines        4319     4323       +4     
  Branches     1152     1155       +3     
==========================================
+ Hits         3110     3147      +37     
+ Misses       1162     1134      -28     
+ Partials       47       42       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.