Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup anchor modifiers #602

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Conversation

sergei-maertens
Copy link
Member

Part of #36

  • Uses the .utrecht-link--current variant in the progress indicator
  • Removed the indent and muted (custom) link variants
  • Includes the (cherry-picked) patch for the hyphenation

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8117bac) 72.97% compared to head (a3cfe62) 71.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   72.97%   71.83%   -1.15%     
==========================================
  Files         213      213              
  Lines        4322     4324       +2     
  Branches     1155     1155              
==========================================
- Hits         3154     3106      -48     
- Misses       1129     1179      +50     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a warning in the console, if we can get rid of this as well.

src/components/Anchor/Anchor.stories.js Outdated Show resolved Hide resolved
src/components/Anchor/Anchor.js Outdated Show resolved Hide resolved
src/components/ProgressIndicator/ProgressIndicatorItem.js Outdated Show resolved Hide resolved
This is no longer used in our code base, instead you should use the
utrecht-link--placeholder variant.
It is unused and does not follow NL DS constructs.
From PR feedback - unused arguments are removed, which allows for
a simpler list building implementation.
@sergei-maertens sergei-maertens force-pushed the chore/36-cleanup-anchor-modifiers branch from 95cfc20 to a3cfe62 Compare November 24, 2023 11:23
@sergei-maertens sergei-maertens merged commit 7f7af26 into main Nov 24, 2023
11 of 12 checks passed
@sergei-maertens sergei-maertens deleted the chore/36-cleanup-anchor-modifiers branch November 24, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants