[#614] Use leaflet-tools

[Viicos]

Fixes #614

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20091ae) 73.02% compared to head (0764db1) 73.44%.

❗ Current head 0764db1 differs from pull request most recent head cf2fe87. Consider uploading reports for the commit cf2fe87 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   73.02%   73.44%   +0.42%     
==========================================
  Files         219      218       -1     
  Lines        4475     4467       -8     
  Branches     1186     1186              
==========================================
+ Hits         3268     3281      +13     
+ Misses       1168     1147      -21     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Viicos]

Hitting a weird test failure. Might be related: Leaflet/Leaflet#6416 (comment)

[sergei-maertens]

I was hoping we could get rid of this file entirely and instead use only the exports from @open-formulieren/leaflet-tools

[Viicos]

We could but there are still some constants specific to the sdk: DEFAULT_LAT_LNG, DEFAULT_ZOOM

[sergei-maertens]

Hitting a weird test failure. Might be related: Leaflet/Leaflet#6416 (comment)

Try updating leaflet to the latest version, this code works in the new form builder 🤔

[Viicos]

Try updating leaflet to the latest version, this code works in the new form builder 🤔

tried with no eval

[Viicos]

Regarding sergei's questions: he asked if it was possible to get rid of the constants module, but the current form builder does not set default values for the center. So did a bit of cleanup but still keeping the module