Localize (validation error) messages #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed it when cleaning up the previous PR
|
Yeah totally forgot about translations 😵💫 |
Ensure the validation error messages are translated and sufficiently accessible for people using screen readers (meaning the field label must be mentioned in the validation error message).
sergei-maertens
force-pushed
the
chore/address-nl-i18n
branch
from
50d4a93 to
f152a1f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
- Coverage 73.28% 73.07% -0.21%
==========================================
Files 216 216
Lines 4436 4450 +14
Branches 1181 1185 +4
==========================================
+ Hits 3251 3252 +1
- Misses 1146 1159 +13
Partials 39 39 ☔ View full report in Codecov by Sentry. |
Viicos
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-formulieren/open-forms#3607