-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OF#180] Add GovMetric #634
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 73.04% 75.12% +2.07%
==========================================
Files 219 224 +5
Lines 4474 4542 +68
Branches 1186 1211 +25
==========================================
+ Hits 3268 3412 +144
+ Misses 1167 1091 -76
Partials 39 39 ☔ View full report in Codecov by Sentry. |
f2ef912
to
4794cb2
Compare
4794cb2
to
92a5b80
Compare
92a5b80
to
8300e5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because the
Yes indeed! I tried combining those into one place. There is still the component taking care of saving the submission halfway through that also uses similar code, but I was worried of breaking it, so I didn't refactor it for now. |
Extra thought: maybe we should always have an abortion button, also if govmetrics isn't enabled 🤔 Then we could refactor |
8740682
to
e6bbcc6
Compare
I think it could be great, as a user I would expect an explicit way to abort, without having to close the browser and wonder about what actually happens when I do so |
Follow up ticket: open-formulieren/open-forms#3791 |
Please see the comments on the Chromatic build - there's some empty blank space now that should ideally not be rendered if the abortion button is not relevant. |
39d2f14
to
d8d8e81
Compare
d8d8e81
to
8845f0b
Compare
Also merged the |
Fixes open-formulieren/open-forms#180
Backend: open-formulieren/open-forms#3775