Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Storybook, MSW and Jest #723

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Conversation

sergei-maertens
Copy link
Member

... what a pain in the bum.

The MSW 1.x -> 2.x really opened Pandora's box. To be continued...

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 80.79470% with 29 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (65b168a) to head (79282ff).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/api-mocks/forms.js 0.00% 9 Missing ⚠️
src/customJestResolver.js 0.00% 7 Missing ⚠️
src/formio/components/FileField.mocks.js 25.00% 6 Missing ⚠️
src/api-mocks/submissions.js 81.25% 3 Missing ⚠️
src/components/EmailVerification/mocks.js 90.90% 1 Missing ⚠️
src/components/FormStep/mocks.js 88.88% 1 Missing ⚠️
src/components/LanguageSelection/mocks.js 91.66% 1 Missing ⚠️
src/components/appointments/mocks.js 97.72% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #723       +/-   ##
===========================================
+ Coverage   56.82%   77.90%   +21.08%     
===========================================
  Files         230      236        +6     
  Lines        4255     4875      +620     
  Branches      772     1333      +561     
===========================================
+ Hits         2418     3798     +1380     
+ Misses       1625     1042      -583     
+ Partials      212       35      -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens force-pushed the chore/upgrade-storybook branch from 086f94c to b0359aa Compare October 24, 2024 08:01
@sergei-maertens sergei-maertens force-pushed the chore/upgrade-storybook branch from 7024248 to 79282ff Compare October 24, 2024 10:23
@sergei-maertens sergei-maertens marked this pull request as ready for review October 24, 2024 10:23
@sergei-maertens sergei-maertens merged commit 4d9e642 into main Oct 24, 2024
15 of 19 checks passed
@sergei-maertens sergei-maertens deleted the chore/upgrade-storybook branch October 24, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant