Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [open-formulieren/open-forms#4546] Properly pass initial_data_reference #727

Merged

Conversation

stevenbal
Copy link
Contributor

needed for open-formulieren/open-forms#4696

previously this was added as a query param to the login URL, but to pass it correctly to the backend it should be added to the nextUrl query params on the login URL

@stevenbal stevenbal force-pushed the issue/4398-properly-pass-initial-data-reference branch from 4fe97c6 to aafcf1c Compare November 5, 2024 11:31
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (6352de4) to head (2eb4c6e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   78.06%   77.84%   -0.22%     
==========================================
  Files         238      238              
  Lines        4938     4939       +1     
  Branches     1348     1348              
==========================================
- Hits         3855     3845      -10     
- Misses       1049     1060      +11     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ence

previously this was added as a query param to the login URL, but to pass it correctly to the backend it should be added to the nextUrl query params on the login URL
@stevenbal stevenbal force-pushed the issue/4398-properly-pass-initial-data-reference branch from c578683 to 2eb4c6e Compare November 5, 2024 12:41
@sergei-maertens sergei-maertens merged commit 3fe8367 into main Nov 5, 2024
14 of 15 checks passed
@sergei-maertens sergei-maertens deleted the issue/4398-properly-pass-initial-data-reference branch November 5, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants