Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating address autocomplete endpoint #746

Merged

Conversation

robinmolen
Copy link
Contributor

Part of open-formulieren/open-forms#3283

Open Forms will no longer support api/v2/location/get-street-name-and-city, so we should use the new endpoint.

…ationData

Open Forms will no longer support /location/get-street-name-and-city. /geo/address-autocomplete is the endpoint that should be used
@robinmolen robinmolen requested a review from stevenbal December 2, 2024 14:04
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (3fc0038) to head (be2eebf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   79.32%   79.56%   +0.24%     
==========================================
  Files         237      237              
  Lines        4962     4962              
  Branches     1350     1358       +8     
==========================================
+ Hits         3936     3948      +12     
+ Misses        995      983      -12     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit e57ff26 into main Dec 2, 2024
15 checks passed
@sergei-maertens sergei-maertens deleted the task/3283-changing-deprecated-address-endpoint branch December 2, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants