Custom map backgrounds #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
+ Coverage 79.22% 79.73% +0.50%
==========================================
Files 238 238
Lines 4973 4974 +1
Branches 1347 1356 +9
==========================================
+ Hits 3940 3966 +26
+ Misses 1004 978 -26
- Partials 29 30 +1 ☔ View full report in Codecov by Sentry. |
robinmolen
requested review from
vaszig
and removed request for
sergei-maertens
robinmolen
force-pushed
the
feature/2173-custom-map-background
branch
from
fe94378 to
4ae2abc
Compare
vaszig
approved these changes
Dec 5, 2024
sergei-maertens
requested changes
Dec 5, 2024
… layer url Allowing the component to determine the background used for the map
…th custom background
robinmolen
force-pushed
the
feature/2173-custom-map-background
branch
from
4ae2abc to
11be47a
Compare
robinmolen
force-pushed
the
feature/2173-custom-map-background
branch
from
daeca51 to
d15d15f
Compare
sergei-maertens
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-formulieren/open-forms#2173
Adds a new property to the LeaftletMap component, named
tileUrl. This allows the use of custom map backgrounds.