Using multiple map interactions #751
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
===========================================
- Coverage 79.51% 57.83% -21.68%
===========================================
Files 239 233 -6
Lines 4979 4352 -627
Branches 1351 798 -553
===========================================
- Hits 3959 2517 -1442
- Misses 989 1615 +626
- Partials 31 220 +189 ☔ View full report in Codecov by Sentry. |
|
Because this feature will be added after 3.0, this PR is moved to draft. This PR is still ready to be reviewed, it just shouldn't be merged just yet |
Added leaflet-draw and react-leaflet-draw as dependencies. These allow easy user interactions with the leaflet map
…ead of coordinates The map component now uses and stores geoJson data, instead of coordinates. This means we can display and work with multiple shapes. One important change is that geoJson saves coordinates as lng-lat, instead of lat-lng
…ponent property With the new property `interactions` the component can defined the possible map interactions. Currently supporting 'marker', 'polygon', 'polyline' and 'circle'
geoJson doesn't differentiate circles from markers, geoJson sees them both as a Point type. To make sure that circles are saved and drawn properly, we have to manually detect and assign the right Leaflet Marker type. To make sure that the circle keeps its size, we save its radius as geoJson property
robinmolen
force-pushed
the
feature/2177-map-interactions
branch
from
95cf149 to
2690059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-formulieren/open-forms#2177
This allows users to interact with the map using multiple tools: markers (the interaction that is already being used), circles, polygons and polylines. With the aim to give users more accurately control. Using the new
interactionsproperty every tool can be included or excluded separately. By default, only the marker will be available to users (conform the current functionality)The different tools result in different data. To accommodate this the data of the component has been changed from an array of numbers, to a geoJson object.
All previously existing functionality has been updated to work with this new data format. This includes:
To accommodate the polyline and polygon, the center point of a shape is used as the centering point. This changes nothing for the marker and circle shapes
This currently also works for the polyline and polygon. Because these shapes consist of multiple points/coordinates, the center point of these shapes is used as the
search nearby addresscoordinates