-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [open-formulieren/open-forms#4918] Pass initial_data_reference when redirecting to formstart #754
🐛 [open-formulieren/open-forms#4918] Pass initial_data_reference when redirecting to formstart #754
Conversation
… redirecting to formstart
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 79.71% 79.78% +0.06%
==========================================
Files 239 239
Lines 4980 4982 +2
Branches 1351 1359 +8
==========================================
+ Hits 3970 3975 +5
+ Misses 980 977 -3
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some polishing :)
src/components/Form.spec.jsx
Outdated
await waitFor(() => { | ||
const loginLink = screen.getByRole('link', {name: buttonText}); | ||
expect(loginLink).toHaveAttribute('href', expectedUrl); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use the findBy*
queries, which are async (and basically put the waitFor
inside the library
await waitFor(() => { | |
const loginLink = screen.getByRole('link', {name: buttonText}); | |
expect(loginLink).toHaveAttribute('href', expectedUrl); | |
}); | |
const loginLink = await screen.findByRole('link', {name: buttonText}); | |
expect(loginLink).toHaveAttribute('href', expectedUrl); |
…a_reference when redirecting
1bb68b9
to
400f735
Compare
Closes open-formulieren/open-forms#4918