Configure Vite to build the SDK #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
+ Coverage 80.10% 80.53% +0.43%
==========================================
Files 238 238
Lines 4951 4953 +2
Branches 1348 1342 -6
==========================================
+ Hits 3966 3989 +23
+ Misses 955 933 -22
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
sergei-maertens
force-pushed
the
chore/npm-package-to-vite
branch
from
643aa30 to
927dae1
Compare
sergei-maertens
force-pushed
the
chore/npm-package-to-vite
branch
from
927dae1 to
4bde5f9
Compare
Slowly preparing to swap over the ESM build for the NPM package from CRA/webpack to Vite. This configuration was hand-crafted. Initially the library build config was used/attempted (see https://v5.vite.dev/config/build-options.html#build-lib), but this proved not to be acceptable since it would inline all the font assets, which blows up the CSS file size to unacceptable sizes. This is very inefficient, since all the font assets would be loaded, even if the browser only requires one type (woff2 vs ttf etc.). It was also inlining the leaflet static images. Using vitejs/vite#3295 (comment) as a reference (which crucially doesn't define build.lib) allows us to configure the underlying rollup setup without inlining assets.
Set up a build directory for vite configuration/plugins to not clutter the vite.config.mts file too much.
sergei-maertens
force-pushed
the
chore/npm-package-to-vite
branch
from
4bde5f9 to
d179ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #758 to be merged first.
Should be a big milestone in #724 provided everything still works as expected
TODO
In a different PR we can then setup ESLint and swap out CRA with Vite 👀
Tested this locally with a form that had a file upload component, optional text fields and date picker, all seems to work as expected. I've also tested the appointment form flow and it also works as expected. Once Open Forms 3.0 is released, this should be good to merge!