Configure coverage flags for storybook/vitest #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook and vitest cover different parts of the codebase, and coverage checks fail sometimes because one is still running/not uploaded yet while the other one is. Tracking the coverage of these separately allows us to better judge which job produces which coverage. Storybook tests should focus on interaction and not much on coverage, whereas vitest tests should ensure sufficient coverage is achieved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
+ Coverage 80.76% 81.85% +1.09%
==========================================
Files 235 235
Lines 4850 4850
Branches 1316 1316
==========================================
+ Hits 3917 3970 +53
+ Misses 901 847 -54
- Partials 32 33 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #724
Storybook and vitest cover different parts of the codebase, and coverage checks fail sometimes because one is still running/not uploaded yet while the other one is. Tracking the coverage of these separately allows us to better judge which job produces which coverage.
Storybook tests should focus on interaction and not much on coverage, whereas vitest tests should ensure sufficient coverage is achieved.