Merge pull request #4535 from open-formulieren/fix/4533-upload-submis…

…sion-csv-checkbox-is-not-updated [#4533] Fix onFieldChange in upload submission csv checkbox (ObjectsAPI)
open-formulieren · Jul 18, 2024 · 14a3007 · 14a3007
2 parents c4b4e8c + 9819ce6
commit 14a3007
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 10 deletions.
diff --git a/src/openforms/js/components/admin/form_design/registrations/objectsapi/LegacyConfigFields.js b/src/openforms/js/components/admin/form_design/registrations/objectsapi/LegacyConfigFields.js
@@ -19,7 +19,7 @@ const LegacyConfigFields = ({index, name, schema, formData, onFieldChange}) => {
     objecttypeVersion = '',
     productaanvraagType = '',
     informatieobjecttypeSubmissionReport = '',
-    uploadSubmissionCsv = '',
+    uploadSubmissionCsv = false,
     informatieobjecttypeSubmissionCsv = '',
     informatieobjecttypeAttachment = '',
     organisatieRsin = '',
@@ -182,8 +182,10 @@ const LegacyConfigFields = ({index, name, schema, formData, onFieldChange}) => {
         <Checkbox
           id="root_uploadSubmissionCsv"
           name="uploadSubmissionCsv"
-          value={uploadSubmissionCsv}
-          onChange={onFieldChange}
+          checked={uploadSubmissionCsv}
+          onChange={e =>
+            onFieldChange({target: {name: 'uploadSubmissionCsv', value: !uploadSubmissionCsv}})
+          }
         />
       </CustomFieldTemplate>
       <CustomFieldTemplate
@@ -319,7 +321,7 @@ LegacyConfigFields.propTypes = {
     objecttypeVersion: PropTypes.string,
     productaanvraagType: PropTypes.string,
     informatieobjecttypeSubmissionReport: PropTypes.string,
-    uploadSubmissionCsv: PropTypes.string,
+    uploadSubmissionCsv: PropTypes.bool,
     informatieobjecttypeSubmissionCsv: PropTypes.string,
     informatieobjecttypeAttachment: PropTypes.string,
     organisatieRsin: PropTypes.string,

diff --git a/...enforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsForm.js b/...enforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsForm.js
@@ -30,7 +30,7 @@ ObjectsApiOptionsForm.propTypes = {
     objecttypeVersion: PropTypes.string,
     productaanvraagType: PropTypes.string,
     informatieobjecttypeSubmissionReport: PropTypes.string,
-    uploadSubmissionCsv: PropTypes.string,
+    uploadSubmissionCsv: PropTypes.bool,
     informatieobjecttypeSubmissionCsv: PropTypes.string,
     informatieobjecttypeAttachment: PropTypes.string,
     organisatieRsin: PropTypes.string,

diff --git a/...s/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js b/...s/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js
@@ -135,7 +135,7 @@ ObjectsApiOptionsFormFields.propTypes = {
     objecttypeVersion: PropTypes.string,
     productaanvraagType: PropTypes.string,
     informatieobjecttypeSubmissionReport: PropTypes.string,
-    uploadSubmissionCsv: PropTypes.string,
+    uploadSubmissionCsv: PropTypes.bool,
     informatieobjecttypeSubmissionCsv: PropTypes.string,
     informatieobjecttypeAttachment: PropTypes.string,
     organisatieRsin: PropTypes.string,

diff --git a/src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js b/src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js
@@ -23,7 +23,7 @@ const V2ConfigFields = ({index, name, schema, formData, onFieldChange, onChange}
     objecttype = '',
     objecttypeVersion = '',
     informatieobjecttypeSubmissionReport = '',
-    uploadSubmissionCsv = '',
+    uploadSubmissionCsv = false,
     informatieobjecttypeSubmissionCsv = '',
     informatieobjecttypeAttachment = '',
     organisatieRsin = '',
@@ -213,8 +213,10 @@ const V2ConfigFields = ({index, name, schema, formData, onFieldChange, onChange}
         <Checkbox
           id="root_uploadSubmissionCsv"
           name="uploadSubmissionCsv"
-          value={uploadSubmissionCsv}
-          onChange={onFieldChange}
+          checked={uploadSubmissionCsv}
+          onChange={e =>
+            onFieldChange({target: {name: 'uploadSubmissionCsv', value: !uploadSubmissionCsv}})
+          }
         />
       </CustomFieldTemplate>
       <CustomFieldTemplate
@@ -304,7 +306,7 @@ V2ConfigFields.propTypes = {
     objecttype: PropTypes.string,
     objecttypeVersion: PropTypes.string,
     informatieobjecttypeSubmissionReport: PropTypes.string,
-    uploadSubmissionCsv: PropTypes.string,
+    uploadSubmissionCsv: PropTypes.bool,
     informatieobjecttypeSubmissionCsv: PropTypes.string,
     informatieobjecttypeAttachment: PropTypes.string,
     organisatieRsin: PropTypes.string,