Skip to content

Commit

Permalink
📝 [#4908] Update TODOs
Browse files Browse the repository at this point in the history
Not relevant anymore or duplicates
  • Loading branch information
viktorvanwijk committed Dec 19, 2024
1 parent 27da770 commit 97e6e6c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {TextInput} from 'components/admin/forms/Inputs';


const RelativeAPIEndpoint = () => {
// TODO-4098: is this the serializer name?
const [fieldProps] = useField('relativeApiEndpoint');
return (
<FormRow>
Expand Down
6 changes: 1 addition & 5 deletions src/openforms/registrations/contrib/json/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,17 @@


class JSONOptionsSerializer(JsonSchemaSerializerMixin, serializers.Serializer):
# TODO-4098: is service enough, or do we need an API group like the ObjectsAPI?
service = PrimaryKeyRelatedAsChoicesField(
queryset=Service.objects.all(),
label=_("Service"),
help_text=_("Which service to use."),
)
# TODO-4098: show the complete API endpoint as a (tooltip) hint after user entry?
# TODO-4098: show the complete API endpoint as a (tooltip) hint after user entry? Might be a front-end thing...
relative_api_endpoint = serializers.CharField(
max_length=255,
label=_("Relative API endpoint"),
help_text=_("The API endpoint to send the data to (relative to the service API root)."),
)
# TODO-4098: should be linked to the checkboxes in the form variable table
# TODO-4098: is it possible to have a choices field of variable keys, where you can select them
# from a drop-down list?
form_variables = serializers.ListField(
child=FormioVariableKeyField(max_length=50),
label=_("Form variable key list"),
Expand Down

0 comments on commit 97e6e6c

Please sign in to comment.