Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary file uploads should not block the deletion of a submission #4763

Closed
sergei-maertens opened this issue Oct 16, 2024 · 0 comments · Fixed by #4805
Closed

Temporary file uploads should not block the deletion of a submission #4763

sergei-maertens opened this issue Oct 16, 2024 · 0 comments · Fixed by #4805
Assignees
@robinmolen
Labels
bug Something isn't working owner: den-haag

Comments

@sergei-maertens
Copy link
Member

Product versie / Product version

2.8.0, possibly 2.7 too

Customer reference

Taiga DH 704

Omschrijf het probleem / Describe the bug

The TemporaryFileUpload records related to a submission block the removal of the submission via the admin interface.

image

Instead, I'd expect these to be cascade deleted along with the submission itself.

The DB model specifies on_delete=models.CASCADE - the model admin has ReadOnlyAdminMixin but maybe this is too much? It was done in 145c22d

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response
@sergei-maertens sergei-maertens added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Oct 16, 2024
@joeribekker joeribekker added owner: den-haag and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Oct 21, 2024
robinmolen added a commit that referenced this issue Oct 31, 2024
@robinmolen
🐛 [#4763] Allow temporary file uploads to be deleted
9d7de8e
@robinmolen robinmolen mentioned this issue Oct 31, 2024
Merged
9 tasks
@robinmolen robinmolen linked a pull request Oct 31, 2024 that will close this issue
🐛 [#4763] Allow temporary file uploads to be deleted #4805
Merged
9 tasks
sergei-maertens added a commit that referenced this issue Oct 31, 2024
@sergei-maertens
Merge pull request #4805 from open-formulieren/bug/4763-temporary-fil…
22d641b 
…e-upload-blocking-submission-deletion

🐛 [#4763] Allow temporary file uploads to be deleted
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
bug Something isn't working owner: den-haag
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 [#4763] Allow temporary file uploads to be deleted open-formulieren/open-forms
3 participants
@joeribekker @sergei-maertens @robinmolen