Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#4763] Allow temporary file uploads to be deleted #4805

Conversation

robinmolen
Copy link
Contributor

Closes #4763

Changes

Temporary file uploads can now be deleted, solving the deletion issue of form submissions with file uploads

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@8f11d28). Learn more about missing BASE report.
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4805   +/-   ##
=========================================
  Coverage          ?   96.56%           
=========================================
  Files             ?      748           
  Lines             ?    25409           
  Branches          ?     3357           
=========================================
  Hits              ?    24535           
  Misses            ?      609           
  Partials          ?      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit 22d641b into master Oct 31, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the bug/4763-temporary-file-upload-blocking-submission-deletion branch October 31, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporary file uploads should not block the deletion of a submission
2 participants