Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubmissionValueVariables of Forms that reuse a FormDefinition are not recoupled to new FormVariables when the FormDefinition is modified #4900

Open
stevenbal opened this issue Dec 10, 2024 · 1 comment · May be fixed by #4964
Open

SubmissionValueVariables of Forms that reuse a FormDefinition are not recoupled to new FormVariables when the FormDefinition is modified #4900

stevenbal opened this issue Dec 10, 2024 · 1 comment · May be fixed by #4964
Assignees
@stevenbal
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Milestone
Release 3.0

Comments

@stevenbal
Copy link
Contributor

Product versie / Product version

3e7b959 / latest

Customer reference

No response

Omschrijf het probleem / Describe the bug

When you modify a FormDefinition that is reused and you save it, the following task is called to repopulate the FormVariables for other Forms that use this definition: https://github.com/open-formulieren/open-forms/blob/master/src/openforms/forms/tasks.py#L91. This means that they are deleted and recreated. After that recouple_submission_variables_to_form_variables which recouples SubmissionValueVariables of the modified Form to the newly created variables. It seems that such a step is missing for the other forms that reuse this definition however

Stappen om te reproduceren / Steps to reproduce

  1. Create form with a reusable formdefinition
  2. Create a second form that reuses this formdefinition
  3. Fill in the second form and submit it

image

  1. Modify the formdefinition in the first form by adding a field and saving
  2. Find the Submission in the admin for the second form and observe that the SubmissionFormVariables are not linked to a FormVariable:
    image

Verwacht gedrag / Expected behavior

The SubmissionValueVariables for other forms should also be recoupled to the new FormVariables

Screen resolution

None

Device

None

OS

None

Browser

No response
@stevenbal stevenbal added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Dec 10, 2024
@stevenbal stevenbal mentioned this issue Dec 10, 2024
Merged
9 tasks
@sergei-maertens
Copy link
Member

When this is picked up, we need to make sure that the test is uncommented: https://github.com/open-formulieren/open-forms/pull/4893/files#r1878343807

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Dec 12, 2024
@sergei-maertens sergei-maertens added this to the Release 3.0 milestone Dec 12, 2024
@sergei-maertens sergei-maertens removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Dec 16, 2024
@stevenbal stevenbal moved this from Todo to In Progress in Development Dec 23, 2024
@stevenbal stevenbal moved this from In Progress to Todo in Development Dec 23, 2024
@stevenbal stevenbal moved this from Todo to In Progress in Development Dec 23, 2024
stevenbal added a commit that referenced this issue Dec 23, 2024
@stevenbal
🐛 [#4900] Recouple SubmissionValueVars for other forms in case of reu…
0f40a4d 
…sable FormDefinitions
@stevenbal stevenbal linked a pull request Dec 23, 2024 that will close this issue
Open
10 tasks
stevenbal added a commit that referenced this issue Dec 23, 2024
@stevenbal
🐛 [#4900] Recouple SubmissionValueVars for other forms for reusable F…
7507b1c 
…ormDefinitions

when bulk updating variables
stevenbal added a commit that referenced this issue Dec 23, 2024
@stevenbal
🐛 [#4900] Recouple SubmissionValueVars for other forms for reusable F…
77429ed 
…ormDefinitions

when bulk updating variables
stevenbal added a commit that referenced this issue Dec 23, 2024
@stevenbal
🐛 [#4900] Recouple SubmissionValueVars for other forms for reusable F…
7ffcbdd 
…ormDefinitions

when bulk updating variables
@stevenbal stevenbal moved this from In Progress to Implemented in Development Dec 23, 2024
stevenbal added a commit that referenced this issue Dec 24, 2024
@stevenbal
🐛 [#4900] Recouple SubmissionValueVars for other forms for reusable F…
f702a31 
…ormDefinitions

when bulk updating variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Projects
Development
Status: Implemented
Milestone
Release 3.0
2 participants
@sergei-maertens @stevenbal