🐛 [#4824] Schedule task to create FormVariables after saving FormStep #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
added
the
needs-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4893 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 757 757
Lines 25945 25965 +20
Branches 3419 3423 +4
=======================================
+ Hits 25069 25089 +20
Misses 613 613
Partials 263 263 ☔ View full report in Codecov by Sentry. |
sergei-maertens
requested changes
Dec 9, 2024
stevenbal
force-pushed
the
issue/4824-missing-formvariable-for-component
branch
from
3a21bec to
0851bab
Compare
this ensures that the Form cannot be left in a broken state with regards to FormVariables, because every component will always have a FormVariable this is a bandaid fix, because ideally we would have a single endpoint and the FormStep wouldn't be updated if there are errors with variables
stevenbal
force-pushed
the
issue/4824-missing-formvariable-for-component
branch
from
0851bab to
b98248f
Compare
sergei-maertens
requested changes
Dec 10, 2024
stevenbal
force-pushed
the
issue/4824-missing-formvariable-for-component
branch
from
b98248f to
87e94c5
Compare
stevenbal
commented
Dec 10, 2024
|
|
||
| self.assertEqual(first_name_submission_var1.form_variable, first_name_var1) | ||
|
|
||
| # with self.subTest( |
There was a problem hiding this comment.
This currently doesn't work, created a separate issue for it #4900
sergei-maertens
approved these changes
Dec 12, 2024
sergei-maertens
deleted the
issue/4824-missing-formvariable-for-component
branch
sergei-maertens
pushed a commit
that referenced
this pull request
Dec 12, 2024
this ensures that the Form cannot be left in a broken state with regards to FormVariables, because every component will always have a FormVariable this is a bandaid fix, because ideally we would have a single endpoint and the FormStep wouldn't be updated if there are errors with variables Backport-of: #4893
sergei-maertens
pushed a commit
that referenced
this pull request
Dec 12, 2024
this ensures that the Form cannot be left in a broken state with regards to FormVariables, because every component will always have a FormVariable this is a bandaid fix, because ideally we would have a single endpoint and the FormStep wouldn't be updated if there are errors with variables Backport-of: #4893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4824 partially
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene