Release 2.4.0 #3579
Merged
Release 2.4.0 #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3579 +/- ##
==========================================
- Coverage 95.97% 95.97% -0.01%
==========================================
Files 679 680 +1
Lines 21859 21888 +29
Branches 2524 2532 +8
==========================================
+ Hits 20979 21006 +27
- Misses 610 611 +1
- Partials 270 271 +1
☔ View full report in Codecov by Sentry. |
sergei-maertens
force-pushed
the
release/2.4.0-beta.0
branch
3 times, most recently
from
f21a8ed to
ae1956e
Compare
While only allowing 'self' makes sense if the forms are only hosted on our own backend, this breaks forms that are embedded on third party domains. These domains need to be allow-listed in the CORS (and CSRF trustlist) policy anyway, so we can use the explicit allow list as a convenience 'automatic' configuration. If this is not sufficient, at the infrastructure level the environment variable 'CSP_EXTRA_FORM_ACTION' can be provided to add extra sources, and as a last resort dynamic configuration through the admin interface is possible.
sergei-maertens
force-pushed
the
release/2.4.0-beta.0
branch
from
3fa86da to
8714e13
Compare
This is so the configuration is run automatically on existing instances, otherwise the lack of form-action directive values combined with our new setting in 2.4 would prevent DigiD/eHerkenning login or payment, unless the admins manually re-save the configuration the admin. This is not manageable if you have many instances.
The amount of get_metadata calls is changed because we directly check the metadata file now instead of fetching a potentially unconfigured source. Additionally, .env overrides for the CSP_FORM_ACTION setting can cause weird local test failures, so we pin that setting the tests that make assertions against the response header.
sergei-maertens
force-pushed
the
release/2.4.0-beta.0
branch
from
81285ca to
ffd35b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3578
Let's see if we can get this properly tested and released without beta's/RC's in between.