Add image scanning

[joeribekker]

Closes open-formulieren/security-issues#10

Second attempt to add non-intrusive image scanning.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b591166) 95.96% compared to head (650caa7) 95.96%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3614   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         683      683           
  Lines       21912    21912           
  Branches     2533     2533           
=======================================
  Hits        21028    21028           
  Misses        611      611           
  Partials      273      273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[sergei-maertens]

From the log output I'm not yet convinced that it's using the locally downloaded/loaded image 🤔

I see that trivy itself is starting a container and mounting some volumes, so this should be double checked.

[joeribekker]

@sergei-maertens maybe we should just do the tarball scan:

    - name: Run Trivy vulnerability scanner in tarball mode
      uses: aquasecurity/trivy-action@master
      with:
        input: /github/workspace/vuln-image.tar
        severity: 'CRITICAL,HIGH'

See: https://github.com/aquasecurity/trivy-action#scanning-a-tarball

[sergei-maertens]

@sergei-maertens maybe we should just do the tarball scan:

    - name: Run Trivy vulnerability scanner in tarball mode
      uses: aquasecurity/trivy-action@master
      with:
        input: /github/workspace/vuln-image.tar
        severity: 'CRITICAL,HIGH'

See: https://github.com/aquasecurity/trivy-action#scanning-a-tarball

yes, that's the way to go! I'll update the PR

I looked into the CodeQL scanning warning too, it's borking on some python syntax so I'm not sure what the proper way to resolve that is, but it's not urgent.