🏷️ Fix generic type hinting of registry #3630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small improvement regarding type checking of the
BaseRegistry
class:I think it doesn't make sense to have a type alias to
type[PluginType_co]
outside any definition, becausePluginType_co
isn't bound to any generic class/function yet.Only downside here is that in
Callable[[type[PluginType_co]], type[PluginType_co]]
,type[PluginType_co]
should also be aTypeVar
bound totype[PluginType_co]
, but typevars bound to other typevars are not allowed.