Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest drf-spectacular #3729

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jan 3, 2024

Nothing seems to be breaking, but this is without OAS 3.1 enabled.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e1987c) 96.05% compared to head (17c1cb4) 96.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3729   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         688      688           
  Lines       22145    22145           
  Branches     2562     2562           
=======================================
  Hits        21271    21271           
  Misses        603      603           
  Partials      271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos
Copy link
Contributor Author

Viicos commented Jan 3, 2024

Last commit requires tfranzel/drf-spectacular#1139

src/openapi.yaml Outdated Show resolved Hide resolved
@Viicos Viicos force-pushed the upgrade-spectacular branch from f45522a to 17c1cb4 Compare January 4, 2024 07:59
Comment on lines -6261 to -6262
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

Comment on lines -7007 to -7008
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

Comment on lines -7036 to -7037
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

Comment on lines -7079 to -7080
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

Comment on lines -7298 to -7299
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually correct, since you can provide a boolean like true to always trigger.

Comment on lines -8727 to -8728
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

Comment on lines -8799 to -8800
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

Comment on lines -8805 to -8806
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

Comment on lines -8952 to -8953
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

Comment on lines -9052 to -9053
type: object
additionalProperties: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3732

@sergei-maertens sergei-maertens merged commit d931ceb into master Jan 4, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the upgrade-spectacular branch January 4, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants