[#3755] Fix datetime validation #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3787 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 706 706
Lines 22182 22185 +3
Branches 2534 2534
=======================================
+ Hits 21385 21388 +3
Misses 549 549
Partials 248 248 ☔ View full report in Codecov by Sentry. |
SilviaAmAm
changed the title
SilviaAmAm
force-pushed
the
fix/3577-datetime-validation
branch
from
5be9b86 to
a6c00a4
Compare
vaszig
approved these changes
Jan 19, 2024
Yes! |
|
To figure out: do we need to do something for the new form builder? Answer: yes |
SilviaAmAm
force-pushed
the
fix/3577-datetime-validation
branch
from
a6c00a4 to
14cef02
Compare
SilviaAmAm
force-pushed
the
fix/3577-datetime-validation
branch
from
14cef02 to
3072601
Compare
sergei-maertens
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3755
Front end PR: open-formulieren/open-forms-sdk#636
Related issue for the date component: #3443