Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4061] Use the right attribute for components array #4077

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Mar 28, 2024

Fixes #4061

@Viicos Viicos requested a review from sergei-maertens March 28, 2024 11:31
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (db0dbd3) to head (a3b5ab1).
Report is 24 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4077   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         728      728           
  Lines       22912    22931   +19     
  Branches     2662     2667    +5     
=======================================
+ Hits        22014    22033   +19     
  Misses        636      636           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit f881bd7 into master Mar 28, 2024
28 checks passed
@sergei-maertens sergei-maertens deleted the issue/4061 branch March 28, 2024 11:42
sergei-maertens pushed a commit that referenced this pull request Mar 28, 2024
sergei-maertens pushed a commit that referenced this pull request Mar 28, 2024
@sergei-maertens
Copy link
Member

Backports:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components in columns missing from logic/location dropdowns
2 participants