Fix validation issue with (dynamically) optional field #4114
Conversation
The component changes properties dynamically, and the logic evaluation seems to be missing some components.
... because of Formio configuration not being updated correctly while the entire submission logic is being evaluated.
sergei-maertens
added
the
needs-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4114 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 730 730
Lines 23090 23090
Branches 2698 2698
=======================================
Hits 22190 22190
Misses 638 638
Partials 262 262 ☔ View full report in Codecov by Sentry. |
| mutation_operations: list[ActionOperation] = [] | ||
| for operation in iter_evaluate_rules(rules, data_container, submission): |
There was a problem hiding this comment.
Probably this can be built using a list comprehension now
There was a problem hiding this comment.
I think a list comprehension makes the code look pure, but it isn't, data mutations are applied as the logic rules are evaluated by looping through them.
No, because the logic evaluation for the entire submission runs after all form steps have been submitted. It was deliberate to skip the property actions, since they affect the UI/client side validation, but that was not presented anymore because the user is on the "confirmation" screen. |
... because of Formio configuration not being updated correctly while the entire submission logic is being evaluated. Backport-of: #4114
|
Backported to stable/2.6.x in b0dc21d |
Taiga DH 671
If the test suite passes first try I'm eating my shoe.Needs backport to stable/2.6.x