Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4115] Extra source ID / secure GUID for GovMetric #4164

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

SilviaAmAm
Copy link
Contributor

Fixes #4115

✨ Needs "forward-port" ✨

@SilviaAmAm SilviaAmAm force-pushed the feature/4115-govmetric-changes branch from 5a13e31 to 507a35f Compare April 12, 2024 10:40
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused that we want to merge this into stable/2.6.x and with the "forward-port" (it's mentioned in the ticket itself but yeah, I don't understand this).

I guess the backwards data migration is useful as well.

@SilviaAmAm SilviaAmAm force-pushed the feature/4115-govmetric-changes branch from 507a35f to 2b3fb37 Compare April 12, 2024 12:30
@sergei-maertens sergei-maertens linked an issue Apr 15, 2024 that may be closed by this pull request
2 tasks
@SilviaAmAm SilviaAmAm marked this pull request as draft April 16, 2024 10:02
@SilviaAmAm SilviaAmAm marked this pull request as ready for review April 16, 2024 10:58
@SilviaAmAm SilviaAmAm requested a review from vaszig April 16, 2024 11:39
@SilviaAmAm
Copy link
Contributor Author

I will wait to merge this until we have done 2.6.5-beta.0

@SilviaAmAm SilviaAmAm force-pushed the feature/4115-govmetric-changes branch from 2b3fb37 to b8cab0d Compare April 19, 2024 09:57
Added to support having different IDs for when the form is finished or aborted
@SilviaAmAm SilviaAmAm force-pushed the feature/4115-govmetric-changes branch from b8cab0d to eaeb29c Compare April 19, 2024 10:41
@SilviaAmAm SilviaAmAm merged commit 81ba6b6 into stable/2.6.x Apr 19, 2024
24 checks passed
@SilviaAmAm SilviaAmAm deleted the feature/4115-govmetric-changes branch April 19, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change GovMetric to use seperate IDs for end of list and abort list
3 participants