-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3725] Add invalid forms (configuration and logic rules) to the email digest #4198
[#3725] Add invalid forms (configuration and logic rules) to the email digest #4198
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4198 +/- ##
==========================================
+ Coverage 96.14% 96.24% +0.09%
==========================================
Files 731 731
Lines 23604 23683 +79
Branches 2773 2790 +17
==========================================
+ Hits 22695 22793 +98
+ Misses 643 622 -21
- Partials 266 268 +2 ☔ View full report in Codecov by Sentry. |
49781f7
to
ec44fc2
Compare
aac469a
to
aee06ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this raises some questions too:
- Should we block JSON logic like
{"var": {"var": "a"}}
? This seems awfully complex for the sort of things we'd like to support. Blocking it allows us to build a logic evaluation dependency tree.
8968b9d
to
1c807d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
7b60e65
to
6274d01
Compare
6274d01
to
bfda2d5
Compare
bfda2d5
to
8ef40fb
Compare
form_logics_vars += [ | ||
var | ||
for var in introspect_json_logic(expression).get_input_keys() | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(no need to fix this, just for the future)
the list comprehension isn't necessary, get_inputs_keys()
already returns a list of input vars:
form_logics_vars += [ | |
var | |
for var in introspect_json_logic(expression).get_input_keys() | |
] | |
form_logics_vars += introspect_json_logic(expression).get_input_keys() |
Fixes #3725 partially