-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4205] Allow any form-action CSP #4223
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4223 +/- ##
==========================================
- Coverage 96.13% 96.12% -0.02%
==========================================
Files 733 729 -4
Lines 23538 23491 -47
Branches 2760 2757 -3
==========================================
- Hits 22629 22580 -49
- Misses 642 645 +3
+ Partials 267 266 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this changeset, but I also think we can/should revert the mechanism then that digid/eherkenning/ogone add extra CSP items in the database, since realistically, that will all be covered by the https:
directive...
Discussed with Joeri - we can remove the DigiD/eHerkenning/OgoneMerchant mechanism that updates the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ogone Merchant CSP update can also be removed :)
As we now allow `https:`, there's no need to whitelist specific URLs from the configuration models (DigiD/eHerkenning)
Fixes #4205.
I'm wondering if it makes sense to keep the
ADDITIONAL_CSP_VALUES
hardcoded values?