Fix type annotations for prefill (plugin) signatures #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
chore/prefill-plugin-signature
branch
from
8638b32 to
860ff09
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4470 +/- ##
==========================================
- Coverage 96.51% 96.51% -0.01%
==========================================
Files 720 720
Lines 23883 23899 +16
Branches 2817 2817
==========================================
+ Hits 23050 23065 +15
- Misses 565 566 +1
Partials 268 268 ☔ View full report in Codecov by Sentry. |
Viicos
approved these changes
Jul 1, 2024
The Sequence is covariant (which the list isn't), which helps in inferring in concrete classes without getting errors about mismatching signatures between parent and subclass.
sergei-maertens
force-pushed
the
chore/prefill-plugin-signature
branch
from
860ff09 to
ee9d63b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue, but came across it as part of #4246 and decided to open a separate PR.
No typing errors anymore with Pyright in Sublime - though I suspect some call-sites may now be messed up. Those should probably be updated rather than messing with the base classes again.
I'm not particularly pleased yet with the type annotation for
attributes- I think it'd be nice if we could dump in a constant/models.TextChoices, but first let's see how #4266 develops first, as that one has dynamic attributes that are not known upfront.