Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record and expose vestiging for eherkenning logins #4484

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Jul 3, 2024

Closes #3967

Changes

  • Updated plugins to extract vestiging / serviceRestriction claim
  • Updated AuthInfo model to store service restriction information & reproduce it in the auth context data format
  • Added static variable to expose the branch number for eherkenning logins

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@sergei-maertens sergei-maertens force-pushed the feature/3967-record-vestiging-eherkenning branch from 5b23649 to be42e89 Compare July 3, 2024 10:29
@sergei-maertens sergei-maertens requested a review from vaszig July 3, 2024 10:32
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (8da2af6) to head (b5e791e).
Report is 534 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4484   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         720      720           
  Lines       24045    24070   +25     
  Branches     2852     2859    +7     
=======================================
+ Hits        23223    23248   +25     
  Misses        559      559           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens force-pushed the feature/3967-record-vestiging-eherkenning branch from be42e89 to ecd3f46 Compare July 3, 2024 11:01
@sergei-maertens sergei-maertens force-pushed the feature/3967-record-vestiging-eherkenning branch from ecd3f46 to b5e791e Compare July 3, 2024 11:04
@sergei-maertens sergei-maertens merged commit 3a2ee7c into master Jul 3, 2024
31 checks passed
@sergei-maertens sergei-maertens deleted the feature/3967-record-vestiging-eherkenning branch July 3, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vestiging to eherkenning auth variable.
2 participants