[#4397] Add query parameter to pass reference to existing object in the Objects API #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaszig
force-pushed
the
task/4397-add-query-param-objectReference-to-the-create-submission
branch
from
399c345 to
43451be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4521 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 719 719
Lines 24065 24077 +12
Branches 2860 2862 +2
=======================================
+ Hits 23241 23253 +12
Misses 560 560
Partials 264 264 ☔ View full report in Codecov by Sentry. |
vaszig
force-pushed
the
task/4397-add-query-param-objectReference-to-the-create-submission
branch
2 times, most recently
from
52f5cad to
0720c04
Compare
Viicos
suggested changes
Jul 12, 2024
vaszig
force-pushed
the
task/4397-add-query-param-objectReference-to-the-create-submission
branch
from
0720c04 to
cfe3771
Compare
Viicos
reviewed
Jul 15, 2024
vaszig
force-pushed
the
task/4397-add-query-param-objectReference-to-the-create-submission
branch
2 times, most recently
from
df4b7a3 to
600aae2
Compare
sergei-maertens
requested changes
Jul 16, 2024
vaszig
force-pushed
the
task/4397-add-query-param-objectReference-to-the-create-submission
branch
from
600aae2 to
32ad9fb
Compare
This is done in order to save the initial data reference which comes from the frontend as a query parameter. It will be used to retreive additional information for the object from the Objects API (we are going to support only this for now)
vaszig
force-pushed
the
task/4397-add-query-param-objectReference-to-the-create-submission
branch
from
32ad9fb to
c83cfb8
Compare
Comment on lines
+247
to
+249
| self.assertEqual( | ||
| submission.initial_data_reference, body["initialDataReference"] | ||
| ) |
There was a problem hiding this comment.
in tests, please make assertions with the literal values instead of referring to variables in tests, that makes it clear what is being compared to what.
so do this instead:
self.assertEqual(submission.initial_data_reference, "of-or-3452fre3")
sergei-maertens
approved these changes
Jul 17, 2024
sergei-maertens
deleted the
task/4397-add-query-param-objectReference-to-the-create-submission
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4397
Changes
object_referenceto theSubmissionmodel in order to save the reference we get from the frontend.This will be used to retrieve further information for the real object
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene