Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more ZGW registration backend issues #4530

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

sergei-maertens
Copy link
Member

Closes #4191

Changes

  • aoaIdentifictie may not be empty
  • handelsnaam must be an array

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Jul 17, 2024
@sergei-maertens sergei-maertens requested a review from Viicos July 17, 2024 07:53
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (b0feb8a) to head (961122c).
Report is 498 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4530   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         719      719           
  Lines       24077    24077           
  Branches     2862     2863    +1     
=======================================
  Hits        23253    23253           
  Misses        560      560           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit f7c5e64 into master Jul 18, 2024
31 checks passed
@sergei-maertens sergei-maertens deleted the issue/4191-more-issues branch July 18, 2024 08:36
sergei-maertens added a commit that referenced this pull request Jul 18, 2024
* aoaIdentificatie may not be empty
* handelsnaam vestiging must be array of strings

Backport-of: #4530
sergei-maertens added a commit that referenced this pull request Jul 18, 2024
* aoaIdentificatie may not be empty
* handelsnaam vestiging must be array of strings

Backport-of: #4530
@sergei-maertens
Copy link
Member Author

Backports: 53b8d46 and 585c5a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing required fields "aoaIdentificatie" in zgw api registration
2 participants